Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Use event category's color for calendar event #441

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

nattsw
Copy link
Contributor

@nattsw nattsw commented Sep 28, 2023

We've hardcoded the events to var(--tertiary). Many users have requested that events be the colour of their categories.

I attempted to add an acceptance test to assert that the colours match the category colours defined in the fixtures, but

query(".fc-event-container").style.backgroundColor

returns 'rgb(37, 170, 226)' value which is slightly annoying to assert against...

Category calendar now:
Screenshot 2023-09-28 at 6 41 36 PM

Upcoming calendar now:
Screenshot 2023-09-28 at 6 53 56 PM

@tgxworld
Copy link
Contributor

returns 'rgb(37, 170, 226)' value which is slightly annoying to assert against...

I think this is fine given that for a given hex value we can only get a certain rgb value.

@renato renato merged commit 5ae1a15 into main Oct 18, 2023
4 checks passed
@renato renato deleted the use-category-color-for-event branch October 18, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants