-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add per-category blocked roles-list #495
base: main
Are you sure you want to change the base?
Conversation
@itzwam how would you use this feature? |
Late reply cuz I didn't see your message, on my side there are some ticketing categories that are allowed for all roles let's say I create 12 roles on my server, I dont want to update the allowed-list with every-roles-but-one, instead I'prefer to specify a blocked role and it works perfectly that's a workflow I already use locally and I would like to upstream this change to the bot cuz I don't think I'm the only one who needs it |
Just figured-out the DB migrations I edited aren't the good ones, think I will need to create new schema migrations files for this specific upgrade, but not sure how to do it properly it "worked" like that but pretty sure I'm not supposed to edit old schema migration scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the SQL files should be reverted.
The process for generating new migrations is to use primsa migrate dev
for each of the providers.
we need to apply change on files and restarting bot or a bit complicated for apply this change? thx |
~ db/postgresql/schema.prisma: ~ db/sqlite/schema.prisma: ~ src/lib/middleware/prisma-sqlite.js: ~ src/lib/tickets/manager.js: ~ src/routes/api/admin/guilds/[guild]/categories/[category]/index.js: ~ src/routes/api/admin/guilds/[guild]/categories/index.js:
Removed schema migrations + squashed things will try to run primsa migrate dev on my side |
Versioning information
Is this related to an issue?
Changes made
Added per-category roles blocklist
Confirmations