Fix skipping in thread pagination #2658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freya022
commented
Apr 19, 2024
| return last.getTimeArchiveInfoLastModified().toString(); | ||
| else if (lastId != 0) | ||
| // If the user skipped ahead | ||
| return TimeUtil.getTimeCreated(lastId).toString(); |
There was a problem hiding this comment.
I'm not sure if this should even be allowed, it's very easy for the user to try to skip using an ID, when in reality it uses the ID as a iso8601 timestamp, requiring to pass the thread archival timestamp, instead of the thread ID.
My use case was to retrieve a channel by ID by making a small window with the pagination, would be much better if JDA had a way to retrieve a channel by ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Attempts to fix thread pagination when using
skipTo, also stops archived threads from being cached, since I assume they would never get removed