Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default implementation for icon shapes #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aandreba
Copy link

@Aandreba Aandreba commented Nov 6, 2024

Since all IconShapes are ZSTs, we can easily derive their Default implementations.

@Aandreba
Copy link
Author

Aandreba commented Nov 6, 2024

I'm having some problems fetching the material icons submodule, so that's why not all of the icons are generated

@marc2332
Copy link
Member

marc2332 commented Nov 7, 2024

I'm having some problems fetching the material icons submodule, so that's why not all of the icons are generated

can't you do something like git submodule update ?

@marc2332 marc2332 self-requested a review November 7, 2024 07:42
@marc2332
Copy link
Member

marc2332 commented Nov 7, 2024

Why exactly do you need to add Derive to the icons? They don't hold any value

@Aandreba
Copy link
Author

Aandreba commented Nov 7, 2024

I'm having some problems fetching the material icons submodule, so that's why not all of the icons are generated

can't you do something like git submodule update ?

I do, but it fails when fetching material icons

@Aandreba
Copy link
Author

Aandreba commented Nov 7, 2024

Why exactly do you need to add Derive to the icons? They don't hold any value

I'm trying to do some stuff with generics and I need the types to implemnent Default

@marc2332
Copy link
Member

marc2332 commented Dec 1, 2024

I'm having some problems fetching the material icons submodule, so that's why not all of the icons are generated

can't you do something like git submodule update ?

I do, but it fails when fetching material icons

What error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants