Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dioxus 0.6 support #55

Merged
merged 5 commits into from
Dec 10, 2024
Merged

feat: Dioxus 0.6 support #55

merged 5 commits into from
Dec 10, 2024

Conversation

marc2332
Copy link
Member

No description provided.

@marc2332 marc2332 added the enhancement New feature or request label Aug 27, 2024
@IroncladDev
Copy link

IroncladDev commented Oct 3, 2024

Just tried this out with the 0.6.0-alpha.2 version of dioxus.

It doesn't compile because there's a comma separating two Elements

packages/lib/src/icon_component.rs

if let Some(title_text) = props.title {
  title {
    "{title_text}"
  }
}, // <-- comma needs to be removed
{props.icon.child_elements()}

packages/example/src/main.rs

h3 { "Frontend that scales." }
p { "Dioxus is a portable, performant, and ergonomic framework for building cross-platform user interfaces in Rust." }, // <-- comma needs to be removed
Icon {
  width: 60,
  height: 60,
  icon: FaRust,
}

@marc2332
Copy link
Member Author

marc2332 commented Oct 3, 2024

Just tried this out with the 0.6.0-alpha.2 version of dioxus.

It doesn't compile because there's a comma separating two Elements

packages/lib/src/icon_component.rs

if let Some(title_text) = props.title {
  title {
    "{title_text}"
  }
}, // <-- comma needs to be removed
{props.icon.child_elements()}

packages/example/src/main.rs

h3 { "Frontend that scales." }
p { "Dioxus is a portable, performant, and ergonomic framework for building cross-platform user interfaces in Rust." }, // <-- comma needs to be removed
Icon {
  width: 60,
  height: 60,
  icon: FaRust,
}

damn it!

@marc2332
Copy link
Member Author

marc2332 commented Oct 3, 2024

Try now @IroncladDev (I haven't tested it myself)

Copy link

@IroncladDev IroncladDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked like a charm

@photino
Copy link

photino commented Dec 10, 2024

Any plan for releasing a new version to support dioxus 0.6?

@marc2332 marc2332 marked this pull request as ready for review December 10, 2024 09:44
@marc2332 marc2332 merged commit 3176e51 into main Dec 10, 2024
2 checks passed
@marc2332 marc2332 deleted the feat/dioxus-0.6 branch December 10, 2024 09:46
@marc2332
Copy link
Member Author

Any plan for releasing a new version to support dioxus 0.6?

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants