-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic test for lazy loading Case Lists #1513
Conversation
Somehow when registering the junit extension in a kotlin unit test with junit, beforAll callback is not getting called at all but only beforeEach. It's possible this might get resolved with Spring Boot 5 update but I am taking the easy way out for now as it doesn't add much overhead
…tain some set of state between tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1513 +/- ##
============================================
+ Coverage 69.93% 69.95% +0.02%
- Complexity 1958 1961 +3
============================================
Files 250 250
Lines 7649 7656 +7
Branches 692 692
============================================
+ Hits 5349 5356 +7
Misses 2037 2037
Partials 263 263 ☔ View full report in Codecov by Sentry. |
@Import(MenuController::class) | ||
@ContextConfiguration(classes = [TestContext::class, CacheConfiguration::class]) | ||
@ExtendWith(InitializeStaticsExtension::class) | ||
class EndpointActionsTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes here are not related to PR and I end up doing it under a wrong assumption, but keeping the changes since it's still a good change to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look and I don't see any issues, but also don't have much knowledge on this area
Thanks @Jtang-1 . merging since these are tests only. |
Tests for dimagi/commcare-core#1388
(Skipping PR Template as there are no functional code changes)