Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fake request for profile cmd so quickcache works properly #35521

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

esoergel
Copy link
Contributor

@esoergel esoergel commented Dec 12, 2024

Product Description

Technical Summary

If no request or task is active, quickcache doesn't use the locmem cache. This makes the profile not an accurate representation of a real restore

Feature Flag

Safety Assurance

Safety story

will be trying this on staging, but at any rate, it only affects a management command

Automated test coverage

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

If no request or task is active, quickcache doesn't use the locmem
cache.  This makes the profile not an accurate representation of a real
restore
@esoergel esoergel requested a review from calellowitz December 12, 2024 21:41
@esoergel esoergel marked this pull request as ready for review December 12, 2024 21:42
@esoergel esoergel requested a review from snopoke as a code owner December 12, 2024 21:42
Copy link
Contributor

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love it, but it does seem better

@esoergel esoergel merged commit bc7939e into master Dec 13, 2024
13 checks passed
@esoergel esoergel deleted the es/mobile-ucr branch December 13, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants