Removed ckeditor5 #35507
Merged
Removed ckeditor5 #35507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
added
the
product/feature-flag
orangejenny
requested review from
esoergel,
a team and
minhaminha
and removed request for
a team
orangejenny
commented
Dec 11, 2024
requirements/dev-requirements.txt
Outdated
| @@ -294,6 +292,7 @@ gnureadline==8.1.2 | |||
| google-api-core==2.11.0 | |||
| # via | |||
| # firebase-admin | |||
| # google-api-core | |||
There was a problem hiding this comment.
@jingcheng16 I'm getting a test error about inconsistent requirements. Didn't you run into this recently?
There was a problem hiding this comment.
Yep. What versions of Python and pip-tools do you have locally? I upgrade pip-tools to 7.4.1 solved the problem.
There was a problem hiding this comment.
I was behind, thank you! Updated and committed new requirements files.
|
Tests passed, ready to go. |
Jtang-1
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
https://dimagi.atlassian.net/browse/USH-5187
This replaces the rich text editor with a plain text area. Existing alerts will still be editable, but they may display differently in email due to the removal of
rich_text_email_styles.cssFeature Flag
Rich text emails
Safety Assurance
Safety story
Limited to a feature flag used by one project. Delivery will be testing on staging.
Automated test coverage
No
QA Plan
Not requesting QA
Rollback instructions
Labels & Review