Removed redundant script tags from ucr_expression.html #35501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Similar to #35438
The ace scripts aren't needed because they're included in
base_acewhich is included here.The hqwebapp and userreports widgets don't appear to be needed on this page - I don't see any of the widgets in those files being used here. I'm guessing this template was originally copied from userreports_base.html.
Feature Flag
UCR expression registry
Safety Assurance
Safety story
Pretty minor change. Local testing and code review should be sufficient for this.
Automated test coverage
no
QA Plan
no
Rollback instructions
Labels & Review