Enterprise Date Range Tiles do not display for translated languages #35499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjriley
changed the title
jingcheng16
approved these changes
Dec 10, 2024
| @@ -93,6 +93,7 @@ def platform_overview(request, domain): | |||
| EnterpriseReport.ODATA_FEEDS, | |||
| EnterpriseReport.SMS, | |||
| )], | |||
| 'uses_date_range': [EnterpriseReport.FORM_SUBMISSIONS, EnterpriseReport.SMS], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
We display a partial template for each enterprise tile. Within that template, there is conditional logic for whether or not to display the date range picker. That logic is currently based on the translated title of the report. This PR switches that to instead be based on the slug, so that translated languages still see the tiles correctly.
It also generalizes the date range logic.
Feature Flag
None
Safety Assurance
Safety story
Locally verified that the tiles continue to display and respond correctly.
Automated test coverage
None
QA Plan
No QA
Rollback instructions
Labels & Review