Add test for recipient filter with FF on #35478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinRiese
force-pushed
the
riese/recipient_filter_additions
branch
from
589ad5c to
94a0b6e
Compare
dimagimon
added
the
Risk: High
MartinRiese
force-pushed
the
riese/recipient_filter_additions
branch
from
a695da4 to
74f0301
Compare
dimagimon
removed
the
Risk: High
MartinRiese
requested review from
a team,
AddisonDunn and
minhaminha
and removed request for
a team
minhaminha
reviewed
Dec 9, 2024
| schedule = TimedSchedule.create_simple_daily_schedule( | ||
| schedule = self._create_schedule(user_data_filter={'role': ['nurse']}) | ||
|
|
||
| TimedSchedule.create_simple_daily_schedule( |
There was a problem hiding this comment.
Does this TimedSchedule still need to be created?
There was a problem hiding this comment.
It does not. Thanks for catching that.
minhaminha
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
https://dimagi.atlassian.net/browse/USH-5154
Feature Flag
INCLUDE_ALL_LOCATIONS
Safety Assurance
Safety story
Automated test coverage
Yes
QA Plan
Rollback instructions
Labels & Review