[B5] Project Limits view migration #35459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingcheng16
force-pushed
the
jc/b5-domain-project-limits
branch
from
526e925 to
2cfb950
Compare
….html' as complete and un-split files."
jingcheng16
added
the
product/admin
millerdev
reviewed
Dec 2, 2024
| @@ -23,8 +23,8 @@ <h1>{{ header }}</h1> | |||
| <td>{{ rate_info.key }}</td> | |||
| <td> | |||
| {{ rate_info.percent_usage }}% | |||
| <div class="progress"> {# todo B5: css-progress #} | |||
| <div class="progress-bar progress-bar-striped" style="width: {{ rate_info.percent_usage }}%"></div> {# todo B5: inline-style #} | |||
| <div class="progress" role="progressbar" aria-label="Percent Usage" aria-valuemin="0" aria-valuemax="100"> | |||
There was a problem hiding this comment.
Should "Percent Usage" be translated?
There was a problem hiding this comment.
The comment in the template explained it is just for internal use so it won't be translated
millerdev
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Before
After
Technical Summary
Ticket: https://dimagi.atlassian.net/browse/SAAS-16335
project_limits.htmldon't have any todo commentsproject_limits_table.htmlonly have 2 todo commentsinline style is still required for progress bar according to [b5 doc] (https://getbootstrap.com/docs/5.3/components/progress/#how-it-works):
Thus I dismissed the
{# todo B5: inline-style#}I have migrated both templates, but
project_limits_table.htmlis also referenced by/Users/jingcheng/commcare-hq/corehq/apps/hqadmin/templates/hqadmin/global_thresholds.htmlthus can not be mark as complete.Feature Flag
Safety Assurance
Safety story
This page is for internal admin usage only.
Automated test coverage
QA Plan
No
Rollback instructions
Labels & Review