Code

Create Invitation API [Validation]#35448

Code

Merged

Jtang-1 merged 45 commits intomasterdimagi/commcare-hq:masterfrom jt/create-user-api-validationdimagi/commcare-hq:jt/create-user-api-validationCopy head branch name to clipboardDec 6, 2024

+590-179

Commits

Commits on Nov 28, 2024

• create class to consolidate validation of web user invitation fields

  Jtang-1

  committed
  2de602f

• this validation is already done as part of django form from CustomDataEditor Form

  Jtang-1

  committed
  1f42d95

• refactor for readability

  Jtang-1

  committed
  b4c260c

• adds function to validate profile

  Jtang-1

  committed
  2873fcb

• refactor validation of email to consolidate

  Jtang-1

  committed
  06e60e1

• do same validation as done for bulk user import in preparation of validating Invitation creation via API

  Jtang-1

  committed
  591245a

• refactor: move validating tableau role and tableau group header to check_headers

  Jtang-1

  committed
  3d99f35

• prefactor - consolidate validation to be used for invitation creation / web user edit API

  Jtang-1

  committed
  9e801be

• refactor: extract required values from spec in higher level function to make it easier to tell what values are needed

  Jtang-1

  committed
  a0119f6

• create validation for location in preparetion for create invitation/update web user API

  Jtang-1

  committed
  0fc4ddd

• refactor: location_ids is the equivalent return

  Jtang-1

  committed
  fc6ced8

• refactor: consolidate validation for location having users

  Jtang-1

  committed
  30a3214

• refactor: consolidate validating that primary location is one of the assigned locations or that primary location is defined if assigned locations is defined

  Jtang-1

  committed
  2e1de11

• refactor to extract out validation of tableau groups from the expected format from spec

  Jtang-1

  committed
  7584aea

• add validation of tableau group to Admin Invites User Validator to be used for invite creation API

  Jtang-1

  committed
  21fd7ac

• prefactor: extract out the validation of the tableau_role independent of the spec format in preparation for reuse

  Jtang-1

  committed
  ff73910

• add validation for tableau role

  Jtang-1

  committed
  cd79129

• add validation for custom data in preparation for web user creation API

  Jtang-1

  committed
  062dde5

• remove unnecessary caching

  Jtang-1

  committed
  f0cd397

• refactor: DRY function

  Jtang-1

  committed
  ef2b0e6

• refactor: The initial purpose of the validation class was to be used for web user API. However, there wasn't as much

  Show description for 64c904a
  Jtang-1

  committed
  64c904a

• perform permission and privilege check only if the parameter exists

  Jtang-1

  committed
  a043006

• remove location fields from backend if location shouldn't be shown

  Jtang-1

  committed
  cca4098

• update test and adds test for validating if invitation email is an existing webuser

  Jtang-1

  committed
  7f3807e

• rename since only one error is returned, not multiple

  Jtang-1

  committed
  8fe97bc

• separate conditionally allowed headers since allowed_headers is globally defined and the conditionally allowed headers should not be preserved upon additional calls to check_header

  Jtang-1

  committed
  998a221

• fix typo

  Jtang-1

  committed
  6366ebf

Commits on Nov 29, 2024

• update test

  Show description for 34e4dc7
  Jtang-1

  committed
  34e4dc7

• test TableauRoleValidation and TableauGroupsValidation

  Jtang-1

  committed
  8d30494

• fix import

  Jtang-1

  committed
  eba62f3

Commits on Nov 30, 2024

• test: new tests for validation of Web User Resourcec

  Jtang-1

  committed
  d9f55a1

• update test so that order doesn't matter for the listed "illegal column headers"

  Jtang-1

  committed
  427420a

Commits on Dec 1, 2024

• update test so it doesn't matter the order of the arguments

  Jtang-1

  committed
  c2df916

Commits on Dec 4, 2024

• delete unused error message. It is now handled in validate_assigned_locations_has_users

  Jtang-1

  committed
  d3b2d3a

• correct patch, path should be where function is used

  Jtang-1

  committed
  eff4a17

• For form validation, clean only occurs if request is post so the "is_post" parameter is redundant.

  Show description for 6f0ec77
  Jtang-1

  committed
  6f0ec77

• fix argument

  Jtang-1

  committed
  ab7e8a7

• fix test - property was moved out of the class

  Jtang-1

  committed
  d698b22

• avoid regenerating list of roles on each call to reduce memory

  Jtang-1

  committed
  11edd76

• bug: needs to check user has access to existing locations when all locations are being removed locs_ids_being_assigned is empty/falsy)

  Jtang-1

  committed
  a5ee207

• rename function for clarity

  Jtang-1

  committed
  33159f5

• remove unneccessary model deletion from test database

  Jtang-1

  committed
  da73efa

Commits on Dec 5, 2024

• clarify naming to distinguish from the form to invite web users

  Jtang-1

  committed
  06dd234

• correct bug where regardless if locations are being changed,

  Show description for 8fee5fe
  Jtang-1

  committed
  8fee5fe

• test: tests that invitiation access is checked even if no locations are changed

  Jtang-1

  committed
  3dfa157