Make sure element has both binding and ix attributes #35247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhaminha
added
the
product/feature-flag
minhaminha
requested review from
MartinRiese,
AddisonDunn,
stephherbers,
Robert-Costello,
Jtang-1 and
nospame
as code owners
dimagimon
added
the
Risk: Medium
nospame
approved these changes
Oct 22, 2024
Comment on lines
708
to
709
| if (Object.prototype.hasOwnProperty.call(element, 'binding') && | ||
| Object.prototype.hasOwnProperty.call(element, 'ix') && allChildren && allChildren.length > 0) { |
There was a problem hiding this comment.
nit: underscore methods could make this cleaner
Suggested change
| if (Object.prototype.hasOwnProperty.call(element, 'binding') && | |
| Object.prototype.hasOwnProperty.call(element, 'ix') && allChildren && allChildren.length > 0) { | |
| if (_.has(element, 'binding') && _.has(element, 'ix') && !_.isEmpty(allChildren)) { |
There was a problem hiding this comment.
applied - I love underscore now
Robert-Costello
approved these changes
Oct 23, 2024
nospame
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This fixes another edge case where if a user tries to change the language in a form that has a multimedia question in it, it'll complain about
element.bindingnot existing.Technical Summary
Jira Ticket
Previously, I changed the conditional to only move into the filename assignment logic if the returned
elementobject wasn't empty but there was another edge case where the returned element could sometimes be a string (language slug). This PR makes is more explicit that it needs both thebindingandixattributes before entering that block.Feature Flag
Multimedia in Web Apps FF
Safety Assurance
Safety story
Tested locally and on staging.
No data impact.
QA Plan
Re-testing with QA because there's been an uptick in bugs around this area recently.
QA Ticket
Rollback instructions
Labels & Review