Improve instructions for deprecated "Web Apps Permissions" feature #35245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adding additional text to the left column so that this option panel isn't pushed under the additional text
…on isn't managed in two locations
dimagimon
added
the
Risk: Medium
Jtang-1
requested review from
esoergel,
MartinRiese,
AddisonDunn,
stephherbers,
Robert-Costello and
nospame
as code owners
orangejenny
approved these changes
Oct 23, 2024
corehq/apps/users/templates/users/partials/edit_role_modal.html
Outdated
Show resolved
Hide resolved
| access.sqlappgroup_set.all().delete() | ||
| access.sqlappgroup_set.set([ | ||
| SQLAppGroup(app_id=app_group['app_id'], group_id=app_group.get('group_id')) | ||
| for app_group in body['app_groups'] | ||
| ], bulk=False) | ||
| access.save() | ||
| if disable_ff and not access.restrict: | ||
| toggles.WEB_APPS_PERMISSIONS_VIA_GROUPS.set(self.domain, False, namespace=toggles.NAMESPACE_DOMAIN) |
| </li> | ||
| <li> | ||
| <strong>(Optional) Deactivate the deprecated feature</strong><br/> | ||
| Although not required for the new setup to work, you can disable the deprecated feature for cleaner management. |
There was a problem hiding this comment.
How about something like, "To prevent this feature being accidentally re-enabled in the future, disable it altogether."?
There was a problem hiding this comment.
I reworded your suggestion a little to " Disable this feature to avoid accidentally re-enabling it in the future." , lmk if you think otherwise
esoergel
approved these changes
Oct 23, 2024
| access.sqlappgroup_set.all().delete() | ||
| access.sqlappgroup_set.set([ | ||
| SQLAppGroup(app_id=app_group['app_id'], group_id=app_group.get('group_id')) | ||
| for app_group in body['app_groups'] | ||
| ], bulk=False) | ||
| access.save() | ||
| if disable_ff and not access.restrict: | ||
| toggles.WEB_APPS_PERMISSIONS_VIA_GROUPS.set(self.domain, False, namespace=toggles.NAMESPACE_DOMAIN) |
corehq/apps/cloudcare/views.py
Outdated
| if disable_ff and not access.restrict: | ||
| toggles.WEB_APPS_PERMISSIONS_VIA_GROUPS.set(self.domain, False, namespace=toggles.NAMESPACE_DOMAIN) | ||
| # This view is not accessible after the FF is disabled | ||
| redirect_url = reverse('users_default', args=[self.domain]) |
There was a problem hiding this comment.
should this direct them to the roles and permissions page instead?
There was a problem hiding this comment.
Yes that would be better 1eed3e8
orangejenny
approved these changes
Oct 24, 2024
…nfiguration exists
orangejenny
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
The goal of these changes are to 1. discourage using both the Roles & Permissions page and the deprecated Manage Web Apps Permissions page simultaneously and 2. provides users with a way to opt out of the deprecated feature.
Summary of Changes:
Before:
After:
Technical Summary
USH-4996
Feature Flag
Relates to web_apps_permissions_via_groups FFthat enabled this deprecated feature for certain domains
Safety Assurance
Safety story
locally tested. The change is limited to altering text or display logic for showing text.
Automated test coverage
no automated test
QA Plan
no QA
Rollback instructions
Labels & Review