Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note on finding areas that need webpack migration #35241

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Added note on finding areas that need webpack migration #35241

merged 2 commits into from
Oct 22, 2024

Conversation

orangejenny
Copy link
Contributor

@gherceg do you think this is worth adding?

Safety Assurance

Safety story

docs only

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added the product/invisible Change has no end-user visible impact label Oct 21, 2024
@orangejenny orangejenny requested review from biyeun and gherceg October 21, 2024 20:47
gherceg
gherceg reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@gherceg gherceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it is worth it. Left one nit.

@orangejenny orangejenny merged commit ddd5096 into master Oct 22, 2024
12 checks passed
@orangejenny orangejenny deleted the jls/webpack-docs branch October 22, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gherceg gherceg gherceg approved these changes

@millerdev millerdev Awaiting requested review from millerdev millerdev is a code owner

@biyeun biyeun Awaiting requested review from biyeun

Assignees
No one assigned
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangejenny @gherceg