Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B5] Exports: create new export #35170

Merged
merged 18 commits into from
Oct 23, 2024
Merged

[B5] Exports: create new export #35170

merged 18 commits into from
Oct 23, 2024

Conversation

orangejenny
Copy link
Contributor

@orangejenny orangejenny commented Oct 3, 2024

Product Description

Joint effort with @AmitPhulera

User-facing changes are pretty minor.

Before

Screenshot 2024-10-03 at 7 39 15 AM
Screenshot 2024-10-03 at 7 39 45 AM
Screenshot 2024-10-03 at 7 39 55 AM

After

Screenshot 2024-10-03 at 7 26 25 AM
Screenshot 2024-10-03 at 7 26 41 AM
Screenshot 2024-10-03 at 7 27 17 AM

Safety Assurance

Safety story

UI-level changes. Requesting QA.

Automated test coverage

I don't think so

QA Plan

https://dimagi.atlassian.net/browse/QA-7132 - joint QA with #35161

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny
Copy link
Contributor Author

Tests fail because I'm holding off on running build_bootstrap5_diffs due to potential conflicts with #35161

I'm not cleaning up the old B3 templates & updating migration status for the same reason, I'll do that in a later PR.

@orangejenny orangejenny added awaiting QA QA in progress. Do not merge product/all-users-all-environments Change impacts all users on all environments labels Oct 3, 2024
Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits up to aefedd4 look good.

I assume you're planning to add an additional commit after running build_bootstrap5_diffs just before this is ready to merge. Is that correct?

@orangejenny
Copy link
Contributor Author

@millerdev yes

@orangejenny orangejenny added QA Passed and removed awaiting QA QA in progress. Do not merge labels Oct 22, 2024
@orangejenny
Copy link
Contributor Author

QA passed and #35161 is merged. I added the B5 diffs, this is now ready to go.

corehq/apps/export/static/export/js/utils.js Outdated Show resolved Hide resolved
corehq/apps/export/static/export/js/utils.js Outdated Show resolved Hide resolved
corehq/apps/export/static/export/js/utils.js Outdated Show resolved Hide resolved
@orangejenny
Copy link
Contributor Author

@gherceg Thank you. Fixed tests for real in d3e0ea1

@orangejenny orangejenny merged commit 7b3ef1c into master Oct 23, 2024
13 checks passed
@orangejenny orangejenny deleted the ap+js/b5-migration branch October 23, 2024 15:36
@orangejenny orangejenny mentioned this pull request Oct 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments QA Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants