Remove bottom margin for gr-has-no-nested-questions

[nospame]

Product Description

Fixes a bug introduced with a recent deploy where nested groups with no visible questions add extra vertical spacing.

Before:

After:

Technical Summary

USH-4154

Feature Flag

Safety Assurance

Safety story

The smallest CSS change to margin, very targeted.

Automated test coverage

n/a

QA Plan

No QA. Support/Delivery to verify on staging.

Rollback instructions

• This PR can be reverted after deploy with no further considerations

Labels & Review

• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[orangejenny]

I wonder if there's any way we could make it more apparent that when updating group styling, you might also need to update these has-no-questions classes. Any bright ideas?

[nospame]

I wonder if there's any way we could make it more apparent that when updating group styling, you might also need to update these has-no-questions classes. Any bright ideas?

@orangejenny My first thought is probably more commenting, but in this case I think changes were made to code generating the elements that happen to get those classes, not even really to the elements or classes themselves, so it would have been easy to miss anyway.

QA honestly seems like the best chance to catch unexpected UI things like this that result from particular configs. I know that I personally would not have considered the case of a group-within-a-group where neither group has any visible questions.

[orangejenny]

@nospame That makes sense, appreciate the thoughts.