Updated build_requirejs string check #34028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esoergel
approved these changes
Jan 24, 2024
|
old feedback, rationale was probably that it doesn't make sense to do a regex search and pass it a plain string rather than a regex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Cherry-picked from another branch that I'm simplifying. @millerdev I think this was PR feedback from you a while back.
Safety Assurance
Safety story
Tiny change to a management command that's part of the deploy process.
Automated test coverage
no
QA Plan
no
Rollback instructions
Labels & Review