Adjust margin for multi select tiles #34025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: Medium
MartinRiese
requested review from
nospame and
Jtang-1
and removed request for
orangejenny
nospame
reviewed
Jan 30, 2024
Comment on lines
292
to
294
| <% if (model.isMultiSelect) { %> | ||
| margin: 10px 30px 0 10px; | ||
| <% } %> |
There was a problem hiding this comment.
Is it intentional that this change (replacing padding: 10px 20px 0 20px;) would remove the previously applied padding any time it's not multi-select?
There was a problem hiding this comment.
Good catch I missed that. Added an else but change it to margin
Jtang-1
approved these changes
Jan 31, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Adjust the margins on multi select case tiles so they are more centered.
Before:
After:
Technical Summary
https://dimagi-dev.atlassian.net/browse/USH-4108
Feature Flag
Safety Assurance
Safety story
Visual change only. Tested locally and on staging
Automated test coverage
No
Rollback instructions
Labels & Review