Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some extra margin to the module-column-name to force wrapping of the text #34020

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

MartinRiese
Copy link
Contributor

@MartinRiese MartinRiese commented Jan 23, 2024

Product Description

There was very little margin around the text on the menu selection screen causing it to get very close to the edge before wrapping. This just adds a little margin to make it break lines faster.

image

Technical Summary

https://dimagi-dev.atlassian.net/browse/USH-4127

Feature Flag

None

Safety Assurance

Safety story

Manually tested locally and on staging with the original app.

Automated test coverage

No, just UI fiddling

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@MartinRiese MartinRiese marked this pull request as ready for review January 24, 2024 20:09
@MartinRiese MartinRiese merged commit 408c0cb into master Jan 26, 2024
12 checks passed
@MartinRiese MartinRiese deleted the riese/home_margin branch January 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants