Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade setup-tools to latest version #34001

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

AmitPhulera
Copy link
Contributor

Product Description

Upgrades setup-tools. This is a multi-major dependency upgrade that should be safe to merge if tests pass.

Technical Summary

Feature Flag

Safety Assurance

Safety story

Should be pretty safe as setuptools is used for packaging the libraries and should not directly affect us.

Automated test coverage

N/A

QA Plan

N/A

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@AmitPhulera AmitPhulera requested a review from a team as a code owner January 22, 2024 12:44
@dimagimon dimagimon added the dependencies Pull requests that update a dependency file label Jan 22, 2024
@millerdev
Copy link
Contributor

Looks like the test failures are due to a deprecated code path invoked by nose. I think a reasonable workaround for this PR is to add an exception in corehq.warnings.WHITELIST. I think it will be better to address that issue by upgrading nose, which should be done separately from this PR.

@AmitPhulera AmitPhulera merged commit fa6a3b6 into master Jan 26, 2024
13 checks passed
@AmitPhulera AmitPhulera deleted the ap/upgrade-setup-tools branch January 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants