Case tiles for case detail #33990
Case tiles for case detail #33990
Conversation
…supports long details
orangejenny
added
the
product/feature-flag
dimagimon
added
the
Risk: Medium
corehq/apps/app_manager/static/app_manager/js/details/screen.js
Outdated
Show resolved
Hide resolved
corehq/apps/app_manager/static/app_manager/js/details/screen.js
Outdated
Show resolved
Hide resolved
| @@ -13,6 +13,10 @@ | |||
| // TODO: to be truly adorable, add transitions on changes to grid style, this doesn't work | |||
| transition: 2s; | |||
|
|
|||
| &.odd-tab { | |||
| background-color: darken(@cc-bg, 3); | |||
There was a problem hiding this comment.
Can we reuse the colors that Jonathan used for the groups?
There was a problem hiding this comment.
These ones? #33801
I like the thought of reusing colors, but those are so dark they seem a bit overwhelming:
| title: detailObject.get('title'), | ||
| }; | ||
| if (detailObject.get('usesCaseTiles')) { | ||
| return views.CaseTileDetailView(menuData); |
There was a problem hiding this comment.
I think CaseDetailTileView would be more descriptive if we could also rename CaseListDetailView to CaseDetailTableView
There was a problem hiding this comment.
Tweaked colors ever so slightly to be more standard: 39cf74a
Doing this because it encourages making the app with a recent CommCare version - new_app deaults to a very old version which triggers this code: https://github.com/dimagi/commcare-hq/blob/d724c1cec867f3a599600e94b67ecc6d3d4f5a80/corehq/apps/app_manager/suite_xml/sections/details.py#L256
| rowClick: function () {}, | ||
| }); | ||
|
|
||
| var initCaseTileList = function (options) { |
There was a problem hiding this comment.
Nice. Could probably also be a const since the views are.
| @@ -473,6 +473,34 @@ hqDefine("cloudcare/js/formplayer/menus/views", function () { | |||
| }, | |||
| }); | |||
|
|
|||
| const CaseTileViewUnclickable = CaseTileView.extend({ | |||
There was a problem hiding this comment.
Seems like the inheritance should be the other way around since CaseTileView has more functionality but I that would probably be tricky.
There was a problem hiding this comment.
I think this makes sense, so I played around with it, but now I'm inclined to leave it as-is. I did a commit that made CaseViewUnclickable the parent view of CaseView, which is fine. CaseTileViewUnclickable can then be a child of CaseViewUnclickable, but CaseTileView needs functionality from both CaseView and CaseTileViewUnclickable which gets messy.
…mcare-hq into jls/case-tile-for-case-detail
orangejenny
added
QA Passed
and removed
awaiting QA
Product Description
https://dimagi-dev.atlassian.net/browse/USH-3873
The related formplayer PR has already been deployed: dimagi/formplayer#1530
Configuration in app manager:
Web Apps UI corresponding to that configuration:
Feature Flag
New flag: USH: Case detail tile
Safety Assurance
Safety story
New feature extending an existing flagged feature. Risk is primarily to case tiles functionality.
Automated test coverage
Tests in PR
QA Plan
https://dimagi-dev.atlassian.net/browse/QA-6030
Rollback instructions
Labels & Review