add methods to reduce complexity

[Robert-Costello]

Product Description

This is to reduce the complexity of edit_module_detail_screens which has been flagged with a HELPME message after radon code static analysis. This change reduced the complexity score from an F to a C

Technical Summary

Feature Flag

Safety Assurance

Safety story

refactor, no logical changes.

Automated test coverage

QA Plan

no QA planned

Rollback instructions

• This PR can be reverted after deploy with no further considerations

Labels & Review

• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[nospame]

I think this looks good. Just to make sure I understand, is the main purpose of this chunk of code is to build and set module.search_config?

[esoergel]

"Hide whitespace" really helps make this readable
https://github.com/dimagi/commcare-hq/pull/33988/files?diff=split&w=1

[Robert-Costello]

"Hide whitespace" really helps make this readable

Wow, that really makes a difference

[Robert-Costello]

I think this looks good. Just to make sure I understand, is the main purpose of this chunk of code is to build and set module.search_config?

@nospame yes, that's right. apologies for the slow response to your question.

[esoergel]

🎉