Use dict.get to specify fallback value

dimagi · Dec 4, 2024 · fb1f4ba · fb1f4ba
1 parent bd58982
commit fb1f4ba
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/corehq/messaging/scheduling/scheduling_partitioned/models.py b/corehq/messaging/scheduling/scheduling_partitioned/models.py
@@ -261,12 +261,8 @@ def _passes_user_data_filter(self, contact):
         else:
             user_data = contact.get_user_data(self.domain)
         for key, value_or_property_name in self.memoized_schedule.user_data_filter.items():
-            if key not in user_data:
-                actual_values_set = {""}
-            else:
-                actual_values_set = self.convert_to_set(user_data[key])
-
             allowed_values_set = {self._get_filter_value(v) for v in self.convert_to_set(value_or_property_name)}
+            actual_values_set = self.convert_to_set(user_data.get(key, ""))
 
             if actual_values_set.isdisjoint(allowed_values_set):
                 return False