Skip to content

Commit

Permalink
Merge pull request #33743 from dimagi/riese/tile_coordinates
Browse files Browse the repository at this point in the history
Remove blank option for row and column
  • Loading branch information
MartinRiese authored Nov 13, 2023
2 parents 2807d31 + b373468 commit 695e0ac
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ hqDefine("app_manager/js/details/column", function () {
self.tileColumnMax = ko.observable(13);
self.tileRowStart = ko.observable(self.original.grid_y + 1 || 1); // converts from 0 to 1-based for UI
self.tileRowOptions = ko.computed(function () {
return [""].concat(_.range(1, self.tileRowMax()));
return _.range(1, self.tileRowMax());
});
self.tileColumnStart = ko.observable(self.original.grid_x + 1 || 1); // converts from 0 to 1-based for UI
self.tileColumnOptions = [""].concat(_.range(1, self.tileColumnMax()));
self.tileColumnOptions = _.range(1, self.tileColumnMax());
self.tileWidth = ko.observable(self.original.width || self.tileRowMax() - 1);
self.tileWidthOptions = ko.computed(function () {
return _.range(1, self.tileColumnMax() + 1 - (self.tileColumnStart() || 1));
Expand Down

0 comments on commit 695e0ac

Please sign in to comment.