Fixed lint errors

dimagi · Oct 21, 2024 · 3ef9756 · 3ef9756
1 parent fca2d62
commit 3ef9756
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 24 deletions.
diff --git a/corehq/apps/hqwebapp/static/hqwebapp/js/bootstrap3/crud_paginated_list.js b/corehq/apps/hqwebapp/static/hqwebapp/js/bootstrap3/crud_paginated_list.js
@@ -57,7 +57,7 @@ hqDefine("hqwebapp/js/bootstrap3/crud_paginated_list", [
         });
 
         self.isPaginatedListEmpty = ko.computed(function () {
-            return self.paginatedList().length == 0;
+            return self.paginatedList().length === 0;
         });
 
         self.isNewListVisible = ko.computed(function () {
@@ -88,12 +88,14 @@ hqDefine("hqwebapp/js/bootstrap3/crud_paginated_list", [
         });
 
         self.allPages = ko.computed(function () {
-            var last_ind = self.maxPage() + 1;
-            if (self.maxPage() <= 5 || self.currentPage() <= 3)
-                return _.range(1, Math.min(last_ind, 6));
-            if (self.currentPage() >= self.maxPage() - 2)
-                return _.range(self.maxPage() - 4, last_ind);
-            return _.range(self.currentPage() - 2, Math.min(last_ind, self.currentPage() + 3));
+            var lastIndex = self.maxPage() + 1;
+            if (self.maxPage() <= 5 || self.currentPage() <= 3) {
+                return _.range(1, Math.min(lastIndex, 6));
+            }
+            if (self.currentPage() >= self.maxPage() - 2) {
+                return _.range(self.maxPage() - 4, lastIndex);
+            }
+            return _.range(self.currentPage() - 2, Math.min(lastIndex, self.currentPage() + 3));
         });
 
         self.utils = {
@@ -196,7 +198,7 @@ hqDefine("hqwebapp/js/bootstrap3/crud_paginated_list", [
             self.changePage(1);
         };
 
-        self.deleteItem = function (paginatedItem, event) {
+        self.deleteItem = function (paginatedItem) {
             var pList = self.paginatedList();
             paginatedItem.dismissModals();
             self.paginatedList(_(pList).without(paginatedItem));
@@ -245,9 +247,10 @@ hqDefine("hqwebapp/js/bootstrap3/crud_paginated_list", [
             return null;
         };
 
-        self.initRow = function (rowElems, paginatedItem) {
+        self.initRow = function () {
             // Intended to be overridden with additional initialization for
             // each row in the paginated list.
+            // Arguments: rowElems, paginatedItem
         };
 
         return self;

diff --git a/corehq/apps/hqwebapp/static/hqwebapp/js/bootstrap5/crud_paginated_list.js b/corehq/apps/hqwebapp/static/hqwebapp/js/bootstrap5/crud_paginated_list.js
@@ -59,7 +59,7 @@ hqDefine("hqwebapp/js/bootstrap5/crud_paginated_list", [
         });
 
         self.isPaginatedListEmpty = ko.computed(function () {
-            return self.paginatedList().length == 0;
+            return self.paginatedList().length === 0;
         });
 
         self.isNewListVisible = ko.computed(function () {
@@ -90,12 +90,14 @@ hqDefine("hqwebapp/js/bootstrap5/crud_paginated_list", [
         });
 
         self.allPages = ko.computed(function () {
-            var last_ind = self.maxPage() + 1;
-            if (self.maxPage() <= 5 || self.currentPage() <= 3)
-                return _.range(1, Math.min(last_ind, 6));
-            if (self.currentPage() >= self.maxPage() - 2)
-                return _.range(self.maxPage() - 4, last_ind);
-            return _.range(self.currentPage() - 2, Math.min(last_ind, self.currentPage() + 3));
+            var lastIndex = self.maxPage() + 1;
+            if (self.maxPage() <= 5 || self.currentPage() <= 3) {
+                return _.range(1, Math.min(lastIndex, 6));
+            }
+            if (self.currentPage() >= self.maxPage() - 2) {
+                return _.range(self.maxPage() - 4, lastIndex);
+            }
+            return _.range(self.currentPage() - 2, Math.min(lastIndex, self.currentPage() + 3));
         });
 
         self.utils = {
@@ -249,9 +251,10 @@ hqDefine("hqwebapp/js/bootstrap5/crud_paginated_list", [
             return null;
         };
 
-        self.initRow = function (rowElems, paginatedItem) {
+        self.initRow = function () {
             // Intended to be overridden with additional initialization for
             // each row in the paginated list.
+            // Arguments: rowElems, paginatedItem
         };
 
         return self;

diff --git a/...webapp/tests/data/bootstrap5_diffs/javascript/hqwebapp/js/crud_paginated_list.js.diff.txt b/...webapp/tests/data/bootstrap5_diffs/javascript/hqwebapp/js/crud_paginated_list.js.diff.txt
@@ -17,18 +17,18 @@
  ) {
      var CRUDPaginatedListModel = function (
          total,
-@@ -196,8 +198,9 @@
+@@ -198,8 +200,9 @@
              self.changePage(1);
          };
 
--        self.deleteItem = function (paginatedItem, event) {
+-        self.deleteItem = function (paginatedItem) {
 +        self.deleteItem = function (paginatedItem, event, button) {
              var pList = self.paginatedList();
 +            $(button).enableButton();
              paginatedItem.dismissModals();
              self.paginatedList(_(pList).without(paginatedItem));
              self.deletedList.push(paginatedItem);
-@@ -221,7 +224,7 @@
+@@ -223,7 +226,7 @@
              });
          };
 
@@ -37,15 +37,15 @@
              $.ajax({
                  url: '',
                  type: 'post',
-@@ -237,6 +240,7 @@
+@@ -239,6 +242,7 @@
                  statusCode: self.handleStatusCode,
                  success: function (data) {
                      self.utils.reloadList(data);
 +                    $(button).enableButton();
                  },
              });
          };
-@@ -267,15 +271,9 @@
+@@ -270,15 +274,9 @@
          };
 
          self.dismissModals = function () {
@@ -64,7 +64,7 @@
              }
          };
 
-@@ -318,15 +316,15 @@
+@@ -321,15 +319,15 @@
              var $deleteButton = $(elems).find('.delete-item-confirm');
              if ($deleteButton) {
                  $deleteButton.click(function () {

diff --git a/corehq/apps/users/static/users/js/edit_commcare_user.js b/corehq/apps/users/static/users/js/edit_commcare_user.js
@@ -37,7 +37,7 @@ hqDefine('users/js/edit_commcare_user', [
         return false;
     });
 
-    $('#reset-password-form').submit(function (e) {
+    $('#reset-password-form').submit(function () {
         $.ajax({
             url: $(this).attr('action'),
             method: $(this).attr('method'),