Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DET errors #239

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Improve DET errors #239

merged 2 commits into from
Apr 8, 2024

Conversation

mkangia
Copy link
Contributor

@mkangia mkangia commented Apr 3, 2024

https://dimagi.atlassian.net/browse/SC-3407

Improving on some validations around expected output filename for the passed in output format.

  1. Taking hints from how the writer is picked for a format, validated the extensions for csv, xls and xlsx. CSV files are actually stored in a zip file. Earlier using csv extension for csv format only gave a warning, we are now making it mandatory.
  2. Additionally, for other non-sql output (json/markdown), validated that an extension is present in output filename, if used.

This will cause errors if users accidentally use the incorrect filenames for passed output format and let users know the fix for the same.

Along with this, a minor change to the error message related to authentication, to let user know that they should also ensure they have access to the project space.

Tested locally.

Also requested for QA here, https://dimagi.atlassian.net/browse/QA-6333

@mkangia mkangia force-pushed the mk/improve-det-errors branch from 4141e9d to a4fcf3f Compare April 4, 2024 17:58
@mkangia mkangia marked this pull request as ready for review April 4, 2024 18:19
Copy link
Contributor

@zandre-eng zandre-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice tests!

@mkangia
Copy link
Contributor Author

mkangia commented Apr 5, 2024

Thanks for the review @zandre-eng
Holding off on merge till QA is concluded, https://dimagi.atlassian.net/browse/QA-6333

@mkangia
Copy link
Contributor Author

mkangia commented Apr 8, 2024

QA passed.

@mkangia mkangia merged commit f850111 into master Apr 8, 2024
5 checks passed
@mkangia mkangia deleted the mk/improve-det-errors branch April 8, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants