Partially reverse "Make language slug available via session metadata" #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on.getCurrentLocale()
This was referenced Oct 23, 2024
shubham1g5
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Users will still be able to reference the current screen's language slug using
instance('commcaresession')/session/context/applanguageImprovement over #1441
Associated dimagi/formplayer#1630
Technical Summary
Shubham pointed out there is an existing function
Localization.getCurrentLocale()that eliminates the need for convoluted ways to pass along the locale value from the initialBaseResponseBean.Safety Assurance
Safety story
Tested locally and on staging. No data impact as the metadata refreshes with every navigation request.
QA Plan
Will have delivery try out their tests once more before merging.
Special deploy instructions
Rollback instructions
Review
Duplicate PR
Automatically duplicate this PR as defined in contributing.md.