Ignore the visit that comes again from hq with same form data #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calellowitz
reviewed
Dec 5, 2024
There was a problem hiding this comment.
This might be nicer as a database level constraint, and then we can catch that db exception in the processor code and respond with an appropriate message. That saves us the extra db hit (its normally just a write that succeeds, and occasionally a write that fails), and enforces the lack of duplicates at the db level, rather than needing to catch it in code each place.
At a minimum we can ensure (xform_id, entity_id, deliver_unit) are unique together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCCT-572