Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup prod env for testing BCP #6157

Merged
merged 27 commits into from
Jan 9, 2024
Merged

Backup prod env for testing BCP #6157

merged 27 commits into from
Jan 9, 2024

Conversation

AmitPhulera
Copy link
Contributor

@AmitPhulera AmitPhulera commented Oct 27, 2023

Opening up this PR to get review on the changes that I am making on top of #4745

Changes till 05950cb have been collaboratively made in presence of @dannyroberts and @gherceg

Rest of the changes I have added by myself, which majorly update the version numbers of the services that we have upgraded.

I have added some comments where I have some doubts.

Environments Affected

backup-production.

@@ -108,7 +112,7 @@ servers:
volume_size: 20
encrypted: yes
group: "couchdb2"
os: bionic
os: bionic # should we change this?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change every occurrence of bionic to jammy, regardless of what's on production

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- form_name
- module_name

KSPLICE_ACTIVE: no # Don't know what this does, this is set to yes in prod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. It's an old thing we don't really use anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to leave. Do whatever staging has I guess

@@ -112,7 +112,7 @@ servers:
volume_size: 20
encrypted: yes
group: "couchdb2"
os: bionic # should we change this?
os: j # should we change this?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah 🤦

@@ -20,6 +20,7 @@ celery_processes:
celery,export_download_queue,reminder_rule_queue,case_import_queue,case_rule_queue:
concurrency: 1
flower: {}
beat: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually specifically do not want this to ever be running on the backup. Probably worth leaving a comment about that. That is because celery beat triggers scheduled events like sending SMS's and such, and we don't want those to get kicked off on the backup environment when we restore the data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason we don't have management_commands above defined. Those contain various enqueuing / scheduling mechanisms that we also don't want to run.

@AmitPhulera AmitPhulera merged commit a68787a into master Jan 9, 2024
2 checks passed
@AmitPhulera AmitPhulera deleted the ap/backup-prod branch January 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants