Updated UI for progress bar in form delivery page #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
previously approved these changes
Nov 28, 2024
avazirna
previously approved these changes
Nov 28, 2024
avazirna
reviewed
Nov 28, 2024
There was a problem hiding this comment.
@pm-dimagi this progress bar is used in a few more UI, were you able to test the contrast of these changes in those places?
|
@pm-dimagi we need a different colour for the progress bar on the app update screen: |
|
@pm-dimagi the area surrounding the progress bar looks fine to me. What I believe is pending here is the progress bar colour in the App update and install screen, this is how it looks now: I think the bar should be in the same colour as the title bar and the recheck button. |
avazirna
previously approved these changes
Dec 3, 2024
avazirna
reviewed
Dec 4, 2024
|
@damagatchi retest this please |
avazirna
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit updates the progress bar, forward/back/close nav buttons, and background color for the navigation pane at the top of the form delivery page. The color changed to match the title bar. The progress bar changed to become vertically narrower, with a dark background and white foreground. The nav buttons were updated to be white, so they stand out against the new background color.
Feature Flag
None
Product Description
The user will see a new look for the controls at the top of form delivery, as shown in the following screenshots.
PR Checklist
[x ] I have confidence that this PR will not introduce a regression for the reasons below
No regression necessary because this change is only to visual elements and does not affect functionality
[x ] Does the PR introduce any major changes worth communicating ? If yes, "Release Note" label is set and a "Release Note" is specified in PR description.
Release note:
Improved progress bar style in form delivery page.
Automated test coverage
No tests effected
Safety story
This change is inherently safe since it simply changes the style of existing elements without modifying the used screen real estate or language.