Button Revamp-Pm ccct 536 #2896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm-dimagi
added
Release Note
High Risk
shubham1g5
requested changes
Nov 15, 2024
Comment on lines
+67
to
+68
| app:roundButtonBackgroundColor="@color/button_primary" | ||
| app:roundButtonTextColor="@color/white"/> |
There was a problem hiding this comment.
can we set a common theme to all buttons instead of specifying the same attributes for all individual rounded buttons ? It will make any changes in future much easier.
|
|
||
| import org.commcare.dalvik.R; | ||
|
|
||
| public class RoundedButton extends androidx.appcompat.widget.AppCompatButton { |
There was a problem hiding this comment.
What's the reason to have own implementation here, seems like Android have inbuild support for rounded buttons
|
@pm-dimagi can we close this out, it was superseded by #2897 right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the design changes and it contains the update of the button all over the app now the square button is converted to the rounded button
Feature Flag
Commcare UI
PR Checklist
Automated test coverage
Safety story