Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: create tag if it does not exist. #168

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

andrewsomething
Copy link
Member

If the tag does not already exist when calling TagResources, we currently error out with a 404. It's a better user experience if we handle the error by creating the tag and trying again.

@andrewsomething andrewsomething requested a review from a team November 7, 2024 20:54
Copy link

@loosla loosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@andrewsomething andrewsomething merged commit 29e42e7 into main Nov 7, 2024
7 checks passed
@andrewsomething andrewsomething deleted the asb/tag-create branch November 7, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants