Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #33 Add snapshot_tags #151

Merged

Conversation

Bryan-Lester-Dolby
Copy link
Contributor

@Bryan-Lester-Dolby Bryan-Lester-Dolby commented Jul 11, 2024

Adds a field, snapshot_tags to the builder that allows the user to specify a list of string tags that will be applied to the snapshot after creation. The core of this fix was proposed by @andiempettJISC in #33 and is a useful feature to developers that rely on tags to filter their images.

Similar functionality exists in other builders, see:
https://developer.hashicorp.com/packer/integrations/hashicorp/oracle/latest/components/builder/oci
https://developer.hashicorp.com/packer/integrations/hashicorp/amazon/latest/components/builder/ebs

Closes #33 . Acceptance tests and documentation included.

End-to-end test of building an image with the new snapshot_tags parameter, and a DigitalOcean API response showing them applied as intended:

image

@Bryan-Lester-Dolby Bryan-Lester-Dolby changed the title Add snapshot_tags Issue #33 Add snapshot_tags Jul 12, 2024
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this great contribution Bryan. 🙏

We'll get a release cut shortly.

@andrewsomething andrewsomething merged commit a4b42c4 into digitalocean:main Jul 12, 2024
7 checks passed
@Bryan-Lester-Dolby
Copy link
Contributor Author

Happy to help! Thank you for prepping a timely release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot Tags
2 participants