builder: initiate image transfers in parallel and make timeout configurable. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
force-pushed
the
asb/issues/125
branch
from
9d07bf4 to
0b85f79
Compare
andrewsomething
changed the title
bentranter
approved these changes
Feb 13, 2024
bentranter
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After resolving #122, we are now properly polling for the status of image transfers. This exposed some issues for users creating large images and distributing them to multiple regions. The transfers are done one at at time. So if the first region errors or times out, the other transfers are never initiated and the initial Droplet is not cleaned up. This PR makes two changes to address this:
Closes: #125
Closes: #129