Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Easegress to marketplace #477

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

LokiWager
Copy link
Contributor

BACKGROUND

  • Add information about the background and reason for the change.
    Easegress is a Cloud Native traffic orchestration system, and we would like to submit it to the marketplace.

Changes

  • List the changes that you made
    Following the Contributing guideline, we add
  • stacks/easegress/deploy.sh
  • stacks/easegress/uninstall.sh
  • stacks/easegress/upgrade.sh
  • stacks/easegress/values.yaml

Checklist

  • review the contributing doc with steps for both adding or updating your application (if applicable)

Reviewer: @marketplace-eng

Copy link
Contributor

@mbeyt mbeyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any errors or issues with installing, so I'm approving and merging to let you move forward with creating a listing, but I'm also lacking any sort of Getting Started instructions, so I can't confirm the app itself works as expected. It would probably be helpful to include something post-install to direct to next steps; at the very least, the listing details should include a Getting Started section when you get to creating it.

@mbeyt mbeyt merged commit 2e484c7 into digitalocean:master Sep 18, 2023
@github-actions
Copy link

👋 @LokiWager
If this is an EXISTING Marketplace app, now that the PR is merged, all new users of your app will get the current version. You should visit the Vendor Portal to make sure you update any version numbers, Description, or Getting Started information that are related to the merged PR.
If this is a BRAND NEW Marketplace app, before this app update can go live on the Marketplace, please update and submit your app from the Vendor Portal.
Thanks!

@LokiWager LokiWager mentioned this pull request Sep 19, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants