Updated list ipv6 response

[imaskm]

No description provided.

[andrewsomething]

Please keep this consistent with existing List methods. For example:

godo/reserved_ips.go

Line 69 in 9338200

func (r *ReservedIPsServiceOp) List(ctx context.Context, opt *ListOptions) ([]ReservedIP, *Response, error) {

We return a slice of the resource while making the pagination info accessible via the Response

godo/godo.go

Lines 165 to 170 in 9338200

	// Links that were returned with the response. These are parsed from
	// request body and not the header.
	Links *Links
	// Meta describes generic information about the response.
	Meta *Meta

[loosla]

👋 Hey Ashwani, Thanks for the PR 🚀.

Here are some suggestions you may consider:

1. Could you please add Links to the ReservedIPV6Resp as it is done here? This will require some changes in Create. You can check reserved ips for reference.

2. Could you also rename ReservedIPV6Resp to reservedIPV6Root for consistency with existing code? 🙏

3. Let's return *ReservedIPV6 instead of *ReservedIPV6Resp for consistency with existing code? 🙏

4. Let's try to reuse reservedIPV6Root in List as it is done here

Please, let me know when you are done. I'll be happy to take a look again 👍

[imaskm]

@loosla

1. We don't have any Links in Create and Get response for IPv6 API.
2. Ok but *Root didn't make sense
3. Ok
4. for list it's plural reservedIPsRoot is being in IPv4

[loosla]

This comment is going to be out of scope of this PR, but it is something we should consider.

Would it be possible to add API documentation for a new /v2/reserved_ipv6 at some point?
This would showcase the fantastic work you’ve done in our publicly available documentation and also help simplify the review process. 🙏

API documentation repo is here - https://github.com/digitalocean/openapi

Many thanks.

[imaskm]

This comment is going to be out of scope of this PR, but it is something we should consider.

Would it be possible to add API documentation for a new /v2/reserved_ipv6 at some point? This would showcase the fantastic work you’ve done in our publicly available documentation and also help simplify the review process. 🙏

API documentation repo is here - https://github.com/digitalocean/openapi

Many thanks.

There is a PR for this: digitalocean/openapi#951

[loosla]

👍 Looks good to me if it aligns with all changes in digitalocean/openapi#951 and that's ok that Links are missing in Create.

[andrewsomething]

🙏 Thanks for the changes!