Hotfix: Fix map layout #3016
Open
Hotfix: Fix map layout #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeandraH
requested review from
steffenkleinle,
ztefanie and
f1sh1918
as code owners
steffenkleinle
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
We currently have the beautiful line
width: ${props => (props.$fullWidth ? '100%' : dimensions.maxWidth - 2 * dimensions.toolbarWidth)}px;in our code which leads to thewidth: 100%px;when$fullWidthistrue. Until merging #3004, that was not a problem (I assume it was overwritten somewhere but I honestly don't see it). After merging #3004, we have a slight layout issue here: https://webnext.integreat.app/augsburg/en/locations This PR fixes that.Proposed changes
pxwhere it belongsmax-widthto account for the$fullWidthpropSide effects
Testing
Look at http://localhost:9000/testumgebung/de/locations in a desktop browser, compare it to https://webnext.integreat.app/augsburg/en/locations.