2548: Split feedback toolbar item component #3015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
steffenkleinle
changed the title
steffenkleinle
requested review from
ztefanie,
f1sh1918 and
LeandraH
as code owners
steffenkleinle
force-pushed
the
2548-proposal
branch
from
9ca9ba6
to
0b8f07f
Compare
LeandraH
approved these changes
Dec 4, 2024
| @@ -15,8 +15,7 @@ type FeedbackContainerProps = { | |||
| noResults?: boolean | |||
| slug?: string | |||
| onSubmit?: () => void | |||
| isPositiveRating: boolean | null | |||
| setIsPositiveRating?: (isPositiveFeedback: boolean | null) => void | |||
| initialRating: boolean | null | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Split feedback toolbar item for better separation of concerns.
Proposed changes
isPositivestate back to FeedbackContainerSide effects
Testing
Check out the feedback items in the toolbar and send some.
Resolved issues
Fixes: #2548
Additonal context
Closed #3012 in favor of this PR.
Discussed in #3004 (comment).