Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1137: Adding new intro slides #3014

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

bahaaTuffaha
Copy link
Contributor

@bahaaTuffaha bahaaTuffaha commented Dec 2, 2024

Short description

Changing and adding new intro slides to look like this here

Proposed changes

  • Added textStyle prop to TextButton to let me change text styling.
  • Because the new images are common across all apps I added them at a new folder : build-configs/common/assets
  • The colors of these new images will change dynamically depending on the theme.(using currentColor)
  • I didn't test it on Malte app (my windows can't run it 😓)

Note: not tested on iOS.

Side effects

  • components/Pagination.tsx
  • components/TextButton.tsx

Testing

  • Just clear the app's data and open the app.
  • The intros should appear ✨.

Fixes: #1137


Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the design, just a few minor comments :) Thank you!
One more thing: Please delete the old assets as they are not needed anymore.

native/src/components/SlideContent.tsx Outdated Show resolved Hide resolved
native/src/routes/Intro.tsx Outdated Show resolved Hide resolved
native/src/routes/Intro.tsx Outdated Show resolved Hide resolved
Comment on lines 16 to 18
/* flex: 1; */
width: 139px;
height: 40px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not set a fixed width and instead approximate it with the corresponding padding, e.g.

Suggested change
/* flex: 1; */
width: 139px;
height: 40px;
padding: 12px 32px;

Copy link
Contributor Author

@bahaaTuffaha bahaaTuffaha Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is StyledButton ...using padding for the button? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the result should be the same right? At least when I tried it.

native/src/routes/Intro.tsx Outdated Show resolved Hide resolved
release-notes/unreleased/1137-Add-intro-slides.yml Outdated Show resolved Hide resolved
native/src/constants/buildConfig.ts Outdated Show resolved Hide resolved
native/src/constants/buildConfig.ts Show resolved Hide resolved
native/src/components/Pagination.tsx Show resolved Hide resolved
native/src/components/Pagination.tsx Outdated Show resolved Hide resolved
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I approved by accident

translations/translations.json Outdated Show resolved Hide resolved
translations/translations.json Outdated Show resolved Hide resolved
translations/translations.json Outdated Show resolved Hide resolved
translations/translations.json Outdated Show resolved Hide resolved
translations/translations.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add intro slides for news and pois and redesign existing
2 participants