-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1137: Adding new intro slides #3014
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the design, just a few minor comments :) Thank you!
One more thing: Please delete the old assets as they are not needed anymore.
/* flex: 1; */ | ||
width: 139px; | ||
height: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not set a fixed width and instead approximate it with the corresponding padding, e.g.
/* flex: 1; */ | |
width: 139px; | |
height: 40px; | |
padding: 12px 32px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is StyledButton ...using padding for the button? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the result should be the same right? At least when I tried it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I approved by accident
Short description
Changing and adding new intro slides to look like this here
Proposed changes
TextButton
to let me change text styling.build-configs/common/assets
currentColor
)Note: not tested on iOS.
Side effects
Testing
Fixes: #1137