Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3008: Hide the loader when first opening the search page #3009

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LeandraH
Copy link
Contributor

Short description

When the search page opens, it shouldn't show a loader while we're loading stuff that the user can't see.

Proposed changes

  • Show only the search bar when the query is empty.

Side effects

  • Should be none

Testing

Compare the loading of https://integreat.app/testumgebung/de/search and http://localhost:9000/testumgebung/de/search

Resolved issues

Fixes: #3008


Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Tested on firefox

web/src/routes/SearchPage.tsx Outdated Show resolved Hide resolved
web/src/routes/SearchPage.tsx Outdated Show resolved Hide resolved
web/src/routes/SearchPage.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show the loader when opening the search page
2 participants