Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1774: Move translations to translations file #1841

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into 1774-move-german-translation-to-translation-…

5c07984
Select commit
Loading
Failed to load commit list.
Open

1774: Move translations to translations file #1841

Merge branch 'main' into 1774-move-german-translation-to-translation-…
5c07984
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 8, 2025 in 41s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.88 -> 9.87)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 3 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method EditUserDialog.tsx: EditUserDialog

✅ Improving Code Health:

  • Complex Method ApplicationCard.tsx: ApplicationCard
  • Complex Method ApiTokenSettings.tsx: ApiTokenSettings
  • Complex Method CardSelfServiceForm.tsx: CardSelfServiceForm

Annotations

Check notice on line 278 in administration/src/bp-modules/applications/ApplicationCard.tsx

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

ApplicationCard decreases in cyclomatic complexity from 13 to 12, threshold = 10. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 157 in administration/src/bp-modules/project-settings/ApiTokenSettings.tsx

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

ApiTokenSettings decreases in cyclomatic complexity from 11 to 10, threshold = 10. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 138 in administration/src/bp-modules/self-service/CardSelfServiceForm.tsx

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

CardSelfServiceForm decreases in cyclomatic complexity from 12 to 11, threshold = 10. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 152 in administration/src/bp-modules/users/EditUserDialog.tsx

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

EditUserDialog increases in cyclomatic complexity from 21 to 22, threshold = 10. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.