Skip to content

Commit

Permalink
Fixes the last unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@digimezzo
digimezzo committed Dec 7, 2024
1 parent a694a9d commit 1e6abed
Show file tree
Hide file tree
Showing 4 changed files with 80 additions and 259 deletions.
4 changes: 3 additions & 1 deletion src/app/app.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import { LifetimeService } from './services/lifetime/lifetime.service';
import { SwitchPlayerService } from './services/player-switcher/switch-player.service';
import { PlaybackService } from './services/playback/playback.service';

jest.mock('jimp', () => ({ exec: jest.fn() }));

describe('AppComponent', () => {
let playerSwitcherServiceMock: IMock<SwitchPlayerService>;
let playbackServiceMock: IMock<PlaybackService>;
Expand Down Expand Up @@ -58,8 +60,8 @@ describe('AppComponent', () => {
addToPlaylistMenuMock.object,
desktopMock.object,
loggerMock.object,
integrationTestRunnerMock.object,
audioVisualizerMock.object,
integrationTestRunnerMock.object,
);
}

Expand Down
266 changes: 29 additions & 237 deletions src/app/services/media-session/media-session.service.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -1,60 +1,26 @@
import { Subject } from 'rxjs';
import { IMock, It, Mock, Times } from 'typemoq';
import { DateTime } from '../../common/date-time';
import { PlaybackInformation } from '../playback-information/playback-information';
import { TrackModel } from '../track/track-model';
import { MediaSessionService } from './media-session.service';
import { PlaybackService } from '../playback/playback.service';
import { PlaybackInformationServiceBase } from '../playback-information/playback-information.service.base';
import { MediaSessionProxy } from '../../common/io/media-session-proxy';
import { Track } from '../../data/entities/track';
import { PlaybackInformationFactory } from '../playback-information/playback-information.factory';
import { TranslatorServiceBase } from '../translator/translator.service.base';
import { DateTime } from '../../common/date-time';
import { TrackModel } from '../track/track-model';
import { Track } from '../../data/entities/track';
import { PlaybackInformation } from '../playback-information/playback-information';

jest.mock('jimp', () => ({ exec: jest.fn() }));

describe('MediaSessionService', () => {
let playbackServiceMock: IMock<PlaybackService>;
let playbackInformationServiceMock: IMock<PlaybackInformationServiceBase>;
let playbackInformationFactoryMock: IMock<PlaybackInformationFactory>;
let mediaSessionProxyMock: IMock<MediaSessionProxy>;
let settingsMock: any;

let playingNextTrack: Subject<PlaybackInformation>;
let playingPreviousTrack: Subject<PlaybackInformation>;

beforeEach(() => {
playbackServiceMock = Mock.ofType<PlaybackService>();
playbackInformationServiceMock = Mock.ofType<PlaybackInformationServiceBase>();
playbackInformationFactoryMock = Mock.ofType<PlaybackInformationFactory>();
mediaSessionProxyMock = Mock.ofType<MediaSessionProxy>();
settingsMock = { enableMultimediaKeys: false };

playingNextTrack = new Subject();
playbackInformationServiceMock.setup((x) => x.playingNextTrack$).returns(() => playingNextTrack.asObservable());

playingPreviousTrack = new Subject();
playbackInformationServiceMock.setup((x) => x.playingPreviousTrack$).returns(() => playingPreviousTrack.asObservable());
});

function createService(): MediaSessionService {
return new MediaSessionService(
playbackServiceMock.object,
playbackInformationServiceMock.object,
mediaSessionProxyMock.object,
settingsMock,
);
}

function createPlaybackInformation(): PlaybackInformation {
const track: Track = new Track('path1');
track.trackTitle = 'title1';
track.artists = 'artist1';
track.albumTitle = 'album1';

const translatorServiceMock: IMock<TranslatorServiceBase> = Mock.ofType<TranslatorServiceBase>();
const dateTimeMock: IMock<DateTime> = Mock.ofType<DateTime>();

const trackModel: TrackModel = new TrackModel(track, dateTimeMock.object, translatorServiceMock.object, settingsMock);

const playbackInformation: PlaybackInformation = new PlaybackInformation(trackModel, 'image1');

return playbackInformation;
return new MediaSessionService(playbackInformationFactoryMock.object, mediaSessionProxyMock.object);
}

describe('constructor', () => {
Expand All @@ -69,156 +35,10 @@ describe('MediaSessionService', () => {
});
});

describe('enableMultimediaKeys', () => {
it('should set settings.enableMultimediaKeys', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = true;

// Assert
expect(service.enableMultimediaKeys).toBeTruthy();
});

it('should get settings.enableMultimediaKeys', () => {
// Arrange
const service: MediaSessionService = createService();
settingsMock.enableMultimediaKeys = true;

// Act & Assert
expect(service.enableMultimediaKeys).toBeTruthy();
});

describe('when set to true', () => {
it('should not clear all multimedia keys handlers', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = true;

// Assert
mediaSessionProxyMock.verify((x) => x.clearActionHandler('play'), Times.never());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('pause'), Times.never());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('previoustrack'), Times.never());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('nexttrack'), Times.never());
});

it('should set all multimedia keys handlers', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = true;

// Assert
mediaSessionProxyMock.verify((x) => x.setActionHandler('play', It.isAny()), Times.once());
mediaSessionProxyMock.verify((x) => x.setActionHandler('pause', It.isAny()), Times.once());
mediaSessionProxyMock.verify((x) => x.setActionHandler('previoustrack', It.isAny()), Times.once());
mediaSessionProxyMock.verify((x) => x.setActionHandler('nexttrack', It.isAny()), Times.once());
});

it('should enable subscriptions so that metadata is set on playing next track', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = true;
playingNextTrack.next(createPlaybackInformation());

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.once());
});

it('should enable subscriptions so that metadata is set on previous track', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = true;
playingPreviousTrack.next(createPlaybackInformation());

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.once());
});
});

describe('when set to false', () => {
it('should clear all multimedia keys handlers', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = false;

// Assert
mediaSessionProxyMock.verify((x) => x.clearActionHandler('play'), Times.once());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('pause'), Times.once());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('previoustrack'), Times.once());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('nexttrack'), Times.once());
});

it('should not set all multimedia keys handlers', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = false;

// Assert
mediaSessionProxyMock.verify((x) => x.setActionHandler('play', It.isAny()), Times.never());
mediaSessionProxyMock.verify((x) => x.setActionHandler('pause', It.isAny()), Times.never());
mediaSessionProxyMock.verify((x) => x.setActionHandler('previoustrack', It.isAny()), Times.never());
mediaSessionProxyMock.verify((x) => x.setActionHandler('nexttrack', It.isAny()), Times.never());
});

it('should disable subscriptions so that metadata is not set on playing next track', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = false;
playingNextTrack.next(createPlaybackInformation());

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.never());
});

it('should disable subscriptions so that metadata is not set on playing previous track', () => {
// Arrange
const service: MediaSessionService = createService();

// Act
service.enableMultimediaKeys = false;
playingPreviousTrack.next(createPlaybackInformation());

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.never());
});
});
});

describe('initialize', () => {
describe('settings.enableMultimediaKeys is true', () => {
it('should not clear all multimedia keys handlers', () => {
// Arrange
settingsMock.enableMultimediaKeys = true;
const service: MediaSessionService = createService();

// Act
service.initialize();

// Assert
mediaSessionProxyMock.verify((x) => x.clearActionHandler('play'), Times.never());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('pause'), Times.never());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('previoustrack'), Times.never());
mediaSessionProxyMock.verify((x) => x.clearActionHandler('nexttrack'), Times.never());
});

it('should set all multimedia keys handlers', () => {
// Arrange
settingsMock.enableMultimediaKeys = true;
const service: MediaSessionService = createService();

// Act
Expand All @@ -230,60 +50,32 @@ describe('MediaSessionService', () => {
mediaSessionProxyMock.verify((x) => x.setActionHandler('previoustrack', It.isAny()), Times.once());
mediaSessionProxyMock.verify((x) => x.setActionHandler('nexttrack', It.isAny()), Times.once());
});

it('should enable subscriptions so that metadata is set on playing next track', () => {
// Arrange
settingsMock.enableMultimediaKeys = true;
const service: MediaSessionService = createService();

// Act
service.initialize();
playingNextTrack.next(createPlaybackInformation());

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.once());
});

it('should enable subscriptions so that metadata is set on playing previous track', () => {
// Arrange
settingsMock.enableMultimediaKeys = true;
const service: MediaSessionService = createService();

// Act
service.initialize();
playingPreviousTrack.next(createPlaybackInformation());

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.once());
});
});
});

describe('settings.enableMultimediaKeys is false', () => {
it('should not enable subscriptions so that metadata is set on playing next track', () => {
// Arrange
settingsMock.enableMultimediaKeys = false;
const service: MediaSessionService = createService();
describe('setMetadataAsync', () => {
it('should set metadata', async () => {
// Arrange
const service: MediaSessionService = createService();
const translatorServiceMock: IMock<TranslatorServiceBase> = Mock.ofType<TranslatorServiceBase>();
const dateTimeMock: IMock<DateTime> = Mock.ofType<DateTime>();
let settingsMock: any = {};

// Act
service.initialize();
playingNextTrack.next(createPlaybackInformation());
const track: Track = new Track('path1');
track.trackTitle = 'title1';
track.artists = 'artist1';
track.albumTitle = 'album1';
const trackModel: TrackModel = new TrackModel(track, dateTimeMock.object, translatorServiceMock.object, settingsMock);

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.never());
});
const playbackInformation: PlaybackInformation = new PlaybackInformation(trackModel, 'image1');

it('should not enable subscriptions so that metadata is set on playing previous track', () => {
// Arrange
settingsMock.enableMultimediaKeys = false;
const service: MediaSessionService = createService();
playbackInformationFactoryMock.setup((x) => x.createAsync(trackModel)).returns(() => Promise.resolve(playbackInformation));

// Act
service.initialize();
playingPreviousTrack.next(createPlaybackInformation());
// Act
await service.setMetadataAsync(trackModel);

// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.never());
});
// Assert
mediaSessionProxyMock.verify((x) => x.setMetadata('title1', 'artist1', 'album1', 'image1'), Times.once());
});
});
});
Loading

0 comments on commit 1e6abed

Please sign in to comment.