Make Dopamine snappier #1172
Open
Make Dopamine snappier #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urmeli0815
force-pushed
the
master
branch
2 times, most recently
from
2fbdcba to
b8578d0
Compare
- parallelized many stuff like retrieving the folder paths, updating the tracks, ... - elevate the usage of SQLite to prevent generation of a lot of objects which need to be garbage collected - added TerminationService to support cancelling of long-running tasks as fast as possible, especially upon termination - activated foreign keys in SQLite database; QueuedTrack now just references Track instead of copying the path data
|
@Urmeli0815 Sorry for the late reply. Thanks a lot for your effort! I will sure take a look at it and use it for improvements. |
|
Will this be added to new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like Dopamine a lot and it is my favorite music player on Windows 10. But I noticed considerable lags when using it with my music collection that resides on a network drive. It takes very long to scan all those titles and even after the whole library was scanned Dopamine still felt laggy in different areas like clicking on an artist or just quitting the application where it hung often.
So I looked at the code and found some areas which can be improved. I took a shot at trying to improve it and got the refresh of the library down from 174sec to 34sec (~80% speed up!).
Changes include:
...
I don't expect this PR to merged as it is but if you want use it as a source of ideas to improve the performance of Dopamine.
Keep up the great work!