Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: another fix for compatability with verbatimModuleSyntax config option #22

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Oct 24, 2024

Similar to #20 , as I was running into the following TS error when having verbatimModuleSyntax: true

ESM syntax is not allowed in a CommonJS module when 'verbatimModuleSyntax' is enabled.

Tested this patch on the repo I'm working with and it seemed to eliminate the type error. As far as I understand, the exported enum is not actually used a value anywhere (there's a similar constant defined in lib/constants.js that's used in the source code)

@coveralls
Copy link

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11506457651

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.405%

Totals Coverage Status
Change from base Build 10220714211: 0.0%
Covered Lines: 328
Relevant Lines: 342

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11506457651

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.405%

Totals Coverage Status
Change from base Build 10220714211: 0.0%
Covered Lines: 328
Relevant Lines: 342

💛 - Coveralls

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. We should just update this to esm at some point.

@achou11 achou11 merged commit d496387 into main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants