Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sharing of observation on Android 12+ #1098

Closed
wants to merge 1 commit into from

Conversation

achou11
Copy link
Member

@achou11 achou11 commented May 22, 2023

Fixes #1097

Notes:

  1. Create observation that has an attachment (e.g. photo)
  2. Open observation screen
  3. Press Share button

@achou11 achou11 requested a review from ErikSin May 22, 2023 16:34
@achou11
Copy link
Member Author

achou11 commented May 22, 2023

noticing that the preview isn't showing up in the share menu. can't remember if that's expected or not but guessing it's not because it shows up in the case where there's no attachments present.

Screen Shot 2023-05-22 at 4 41 23 PM

seeing the same thing as react-native-share/react-native-share#613 in adb logs - wondering if that's related. not really sure how to fix, but this doesn't seem to actually break the sharing itself, so hopefully not a major blocker for this PR

UPDATE: this is not a regression as this is the previously observed behavior for observations without attachments, so please ignore this comment 😄

@achou11 achou11 mentioned this pull request May 25, 2023
@achou11
Copy link
Member Author

achou11 commented May 25, 2023

Closing in favor of #1099

@achou11 achou11 closed this May 25, 2023
@achou11 achou11 requested a review from gmaclennan June 6, 2023 15:18
@achou11 achou11 deleted the 1097/obs-share-android-12 branch June 7, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sharing observation containing attachment does not work on Android 12+
1 participant