chore: don't sync semver tags for releases #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the equivalent to [this change][0]. To quote that commit:
> The optic release option `sync-semver-tags` creates additional tags
> (`v{MAJOR}`, `v{MAJOR}.{MINOR}`) which are updated on each release.
> This currently does not work because this tag push happens with the
> permissions of the default github actions token, which does not have
> rule bypass permissions. It's a "soft fail" (the release still gets
> made), and the full version tag comes from the release creation, which
> is done by the optic release app, which is included in our ruleset
> bypass list.
>
> We don't need these tags, and they are not working, so this [commit]
> turns this option off.
[0]: digidem/comapeo-core@d3dc9d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent to this change. To quote that commit:
I plan to YOLO-merge this if CI passes.