Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add self-hosted server details to DeviceInfo #273

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: add self-hosted server details to DeviceInfo #273

merged 1 commit into from
Oct 22, 2024

Conversation

EvanHahn
Copy link
Contributor

This adds a new object, selfHostedServerDetails, to DeviceInfo. It currently has one property, baseUrl, but could have more later.

See #268 where this was originally added.

Closes #272.

@EvanHahn
feat: add self-hosted server details to DeviceInfo
71aa527 
This adds a new object, `selfHostedServerDetails`, to `DeviceInfo`. It
currently has one property, `baseUrl`, but could have more later.

See [#268].

[#268]: #268
gmaclennan
gmaclennan approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, looks good.

@EvanHahn EvanHahn merged commit f7ae02a into main Oct 22, 2024
6 checks passed
@EvanHahn EvanHahn deleted the server branch October 22, 2024 18:01
@optic-release-automation optic-release-automation bot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees
No one assigned
Labels
Project: Community Server v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add add self-hosted server details to DeviceInfo
2 participants
@EvanHahn @gmaclennan