Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/arm64 - integration test with test containers to test docker build and run #125

Merged
merged 51 commits into from
Jan 22, 2025

Conversation

syedhasandigi
Copy link
Contributor

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

High level description

Detailed description

Describe alternatives you've considered

Operational impact

Additional context

@syedhasandigi
Copy link
Contributor Author

https://security.stackexchange.com/questions/219577/how-to-securely-run-puppeteer-chromium-in-a-docker-container

This question describes our problem best imho.
There seems to be interest in adding a feature to allow --security-opts flag to be passed in test containers testcontainers/testcontainers-node#841

I guess we wait for this feature to be added?

docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment from @jonmattgray

Visualiser service scaled to 0 in compose file, Readme updated
@syedhasandigi syedhasandigi added the v:patch Change requires a semver patch version change label Jan 22, 2025
@syedhasandigi syedhasandigi merged commit a37cc99 into main Jan 22, 2025
10 checks passed
@syedhasandigi syedhasandigi deleted the feat/arm64 branch January 22, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v:patch Change requires a semver patch version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants